icemelon9 commented on a change in pull request #8266:
URL: https://github.com/apache/tvm/pull/8266#discussion_r654876186
##########
File path: tests/python/unittest/test_arith_rewrite_simplify.py
##########
@@ -293,6 +294,9 @@ def test_sub_index_simplify():
# mul co-efficient foldng
ck.verify(x - x, 0)
+ ck.verify(a - a, 0)
+ ck.verify(a - b, a - b)
+ ck.verify(a - b, c - c)
Review comment:
Not simplifying `a - b` is correct, but I think `a - b` is not
structural equal to `c - c` as `a` and `b` refer to two different variable but
`c - c` are the same variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
