mikepapadim commented on pull request #8302:
URL: https://github.com/apache/tvm/pull/8302#issuecomment-866779625
> @mikepapadim Thanks! It's really great to have type check for python
codes. While seems the CI failed on mypy but it didn't throw any error?
>
> In my understanding, mypy requires python files to specifie data type
explicitly for function parameters and return values, but we have not yet add
the missing data type to these two dirs in this PR?
@jcf94 you are right. This PR does not fix the missing data types, it is
only enables MyPy.
At this point error logging is disabled ( by setting `ignore_errors` in
`mypy.ini`). So, thats why at the end of the linting stage in Jenkins there is
the following:
```
Checking MyPy Type defs in auto_scheduler package.
Success: no issues found in 17 source files
Checking MyPy Type defs in runtime package.
Success: no issues found in 13 source files
```
These two dirs are serving as placeholders atm.
Ideally, this PR adds the basic functionality.
Then, subsequent PRs can start incrementally to fix data types in specifics
dirs and enable them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
