masahi commented on a change in pull request #8309:
URL: https://github.com/apache/tvm/pull/8309#discussion_r657439786
##########
File path: src/relay/op/tensor/transform.cc
##########
@@ -2668,8 +2668,9 @@ Array<Array<Layout>> StridedSliceInferCorrectLayout(const
Attrs& attrs,
params->begin = new_begin;
params->end = new_end;
}
+ return InferCorrectLayoutOutput({{layout}, {layout}}, Attrs(params));
}
- return {{layout}, {layout}};
+ return InferCorrectLayoutOutput({{layout}, {layout}}, attrs);
Review comment:
`out_default` is `{{Layout::Undef()}, {Layout::Undef()}}`, here we do
want to return non-null layout. I don't know if this distinction is
intentional, but I think `Layout::Undef()` implies failure while `{{layout},
{layout}}` implies success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
