trevor-m commented on a change in pull request #8323:
URL: https://github.com/apache/tvm/pull/8323#discussion_r658113381
##########
File path: python/tvm/contrib/target/onnx.py
##########
@@ -617,6 +617,20 @@ def convert_attributes(cls, attrs):
return {"value": 1}
+class LRN(OpConverter):
+ """Operator converter for LRN."""
+
+ @classmethod
+ def convert_attributes(cls, attrs):
+ return {
+ "alpha": attrs.alpha,
+ "beta": attrs.beta,
+ "bias": attrs.bias,
+ "size": attrs.size
+ # axis?
Review comment:
Remove comment.
It looks like the ONNX LRN op doesn't have an axis parameter, as it always
applies to axis 1.
Should be add an assert somewhere to check that the axis is also 1 in the
Relay operator that is being converted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
