leandron commented on issue #8177:
URL: https://github.com/apache/tvm/issues/8177#issuecomment-868676915


   > A question on the rebuilds overall. Beyond just the version dependencies, 
we've had a few cases where the built images would result in failing unit tests 
(e.g. #8339). Would it be good to add running the unit tests to the 
Dockerfiles? Since we need to test the built images anyways before using them, 
that would make the testing of each image, with unit tests appropriate for that 
image, be automatic as part of the build process.
   
   I think running TVM unit tests would imply in also building TVM as part of 
the Docker image rebuild, which doesn't make much sense. Based on that, I think 
we should avoid adding the unit tests as part of the Dockerfiles themselves.
   
   IMHO, it would be better just to be able to qualify images in a systematic 
way, as part of the release of new images.
   
   We are currently working on a way to improve the image rebuild testing, and 
making it a daily Jenkins job in the upstream CI. The next logical step is to 
validate the images using the regular TVM build process, pointing to "staging" 
docker images.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to