chiwwang commented on a change in pull request #8220:
URL: https://github.com/apache/tvm/pull/8220#discussion_r659458980



##########
File path: docs/dev/pass_infra.rst
##########
@@ -389,6 +396,103 @@ To allow other C++ modules to apply this pass, we declare 
a free function in
 
     TVM_DLL Pass FoldConstant();
 
+.. _pass_instrument_section_tag:
+
+Pass Instrument

Review comment:
       It would be nice! But after trying and reading around, I find 
PassInstrument might require understanding PassContext first to know about what 
each instrument points means.
   Perhaps we can split PassInstrument doc out once it becomes bigger (such as 
more and more built-in instruments are added, or new functionality added to 
provide more instrumentation possibility?)
   
   I also tried to shrink Python docs a little. Thanks a lot for suggestions :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to