mbrookhart commented on a change in pull request #8313:
URL: https://github.com/apache/tvm/pull/8313#discussion_r660126055
##########
File path: src/relay/transforms/pattern_utils.h
##########
@@ -700,6 +700,13 @@ Expr StopFusion(Expr data);
Expr CastHint(Expr data, DataType dtype);
+inline Expr Concat(Expr x, int axis = 0) {
+ static const Op& op = Op::Get("concatenate");
+ auto attrs = make_object<ConcatenateAttrs>();
+ attrs->axis = axis;
+ return Call(op, {x}, Attrs(attrs), {});
+}
Review comment:
Maybe just use the version here instead of duplicating?
https://github.com/apache/tvm/blob/2915349458619deb5bd9b03670b33205938a8c02/src/relay/op/make_op.h#L45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
