comaniac commented on pull request #8363: URL: https://github.com/apache/tvm/pull/8363#issuecomment-870112769
> Equality check is another big issue. I discussed with @comaniac a while ago, but haven’t got a conclusion yet when should two targets are considered “equal”: If one target has -libs=cudnn and the other doesn’t, are they equal to each other? Exactly. It seems to me that we ultimately need two APIs for target: one (i.e., `==`) checks if two targets are exactly the same, and the other (`.compatible(self, other)`) checks if target A is compatible to target B. The problem is the definition of "compatible" targets. In my own experience, `compatible` is much more useful than `==`, as in many cases, people care more about whether a model/schedule built with target A can be used in target B. Meanwhile, we can still have the equality check first for internal use cases like this one I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
