AnastasiaStulova commented on pull request #8361: URL: https://github.com/apache/tvm/pull/8361#issuecomment-871364901
> > This patch looks good to me, ideally we should have test cases for this though. I'm not up to speed on the status of Arm CI so am unsure how immediately feasible this is, perhaps @u99127 or @leandron know more. > > do the existing topi tests catch the failure on AArch64 ? @u99127 The test indeed caught the bug and it already what we need for `arm_cpu` testing https://github.com/apache/tvm/blob/main/tests/python/topi/python/test_topi_conv2d_nhwc.py#L33 but it is not enabled by default in the list of tested devices: https://github.com/apache/tvm/blob/main/tests/python/topi/python/test_topi_conv2d_nhwc.py#L78 It is very easy to add it to the list `"llvm -device=arm_cpu"` then it runs straight away. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
