wrongtest commented on a change in pull request #8338:
URL: https://github.com/apache/tvm/pull/8338#discussion_r662713011
##########
File path: src/tir/transforms/storage_rewrite.cc
##########
@@ -504,8 +503,13 @@ class StoragePlanRewriter : public StmtExprMutator {
return MergeNest(nest, body);
}
// Remap the index
- PrimExpr RemapIndex(DataType dtype, PrimExpr index, StorageEntry* e) {
+ PrimExpr RemapIndex(PrimExpr index, StorageEntry* e) {
Review comment:
In my understanding the most correct dtype to use is the buffer data
type itself. The `dtype` param before is load_op->dtype or store_op->dtype from
context.
If the buffer dtype has non-trivial lanes like `tir.allocate([n],
"float32*4")` (I'm not sure if it is possible), it seems not clear which factor
to use based on original dtype param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
