leandron commented on a change in pull request #8386:
URL: https://github.com/apache/tvm/pull/8386#discussion_r662869046
##########
File path: python/tvm/micro/contrib/zephyr.py
##########
@@ -408,6 +408,7 @@ def _get_nrf_device_args(self):
BOARD_USB_FIND_KW = {
"nucleo_f746zg": {"idVendor": 0x0483, "idProduct": 0x374B},
"stm32f746g_disco": {"idVendor": 0x0483, "idProduct": 0x374B},
+ "nucleo_l4r5zi": {"idVendor": 0x0483, "idProduct": 0x374B},
Review comment:
```suggestion
"nucleo_l4r5zi": {"idVendor": 0x0483, "idProduct": 0x374B},
"nucleo_f746zg": {"idVendor": 0x0483, "idProduct": 0x374B},
"stm32f746g_disco": {"idVendor": 0x0483, "idProduct": 0x374B},
```
This is a massive nit, but I suggest we keep the boards, for our own sanity,
alphabetically here, where possible.
##########
File path: python/tvm/target/target.py
##########
@@ -284,6 +284,7 @@ def intel_graphics(model="unknown", options=None):
"stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
"nrf5340dk": ["-mcpu=cortex-m33"],
"mps2_an521": ["-mcpu=cortex-m33"],
+ "stm32l4r5zi": ["-mcpu=cortex-m4"],
Review comment:
```suggestion
"mps2_an521": ["-mcpu=cortex-m33"],
"nrf5340dk": ["-mcpu=cortex-m33"],
"stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
"stm32l4r5zi": ["-mcpu=cortex-m4"],
```
Again, this is a massive nit, but I suggest we keep the boards, for our own
sanity, alphabetically here, where possible.
##########
File path: tests/micro/zephyr/conftest.py
##########
@@ -27,6 +27,7 @@
"stm32f746xx_nucleo": ("stm32f746xx", "nucleo_f746zg"),
"stm32f746xx_disco": ("stm32f746xx", "stm32f746g_disco"),
"nrf5340dk": ("nrf5340dk", "nrf5340dk_nrf5340_cpuapp"),
+ "stm32l4r5zi_nucleo": ("stm32l4r5zi", "nucleo_l4r5zi"),
"mps2_an521": ("mps2_an521", "mps2_an521-qemu"),
Review comment:
```suggestion
"mps2_an521": ("mps2_an521", "mps2_an521-qemu"),
"nrf5340dk": ("nrf5340dk", "nrf5340dk_nrf5340_cpuapp"),
"stm32f746xx_disco": ("stm32f746xx", "stm32f746g_disco"),
"stm32f746xx_nucleo": ("stm32f746xx", "nucleo_f746zg"),
"stm32l4r5zi_nucleo": ("stm32l4r5zi", "nucleo_l4r5zi"),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
