echuraev commented on pull request #8388: URL: https://github.com/apache/tvm/pull/8388#issuecomment-873876294
> I see some lines in rpc_env.cc that reference .so and .dll files. I think you need to expand these to also support .dylib. I double-checked and `.dylib` is already supported. We use the modified functions `GenerateUntarCommand`, `LinuxShared` and `CreateShared` only in the function `BuildSharedLibrary` (https://github.com/echuraev/tvm/blob/echuraev/fix_cpp_rpc/apps/cpp_rpc/rpc_env.cc#L292). Function `BuildSharedLibrary` returns the name of the file which will be used in `Module::LoadFromFile` (https://github.com/echuraev/tvm/blob/echuraev/fix_cpp_rpc/apps/cpp_rpc/rpc_env.cc#L129). In case when we would like to load `dylib` the `BuildSharedLibrary` should return the name of the `dylib` library. And it works in this way. [Here](https://github.com/echuraev/tvm/blob/echuraev/fix_cpp_rpc/apps/cpp_rpc/rpc_env.cc#L315) we return the name of the `dylib` library. We could do it explicitly by adding a condition (such as: `|| support::EndsWith(file, ".dylib")`) [here](https://github.com/echuraev/tvm/blob/echuraev/fix_cpp_rpc/apps/cpp_rpc/rpc_env.cc#L293). But I think it will be redundantly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
