tqchen commented on a change in pull request #7983:
URL: https://github.com/apache/tvm/pull/7983#discussion_r668121949
##########
File path: include/tvm/runtime/profiling.h
##########
@@ -150,6 +151,26 @@ class Timer : public ObjectRef {
Timer DefaultTimer(Device dev);
namespace profiling {
+/*! \brief Wrapper for `Device` because `Device` is not passable across the
Review comment:
Device cannot be put as part of object container. How about DeviceObject?
##########
File path: include/tvm/runtime/profiling.h
##########
@@ -210,16 +282,21 @@ struct CallFrame {
Timer timer;
/*! Extra performance metrics */
std::unordered_map<std::string, ObjectRef> extra_metrics;
+ /*! User defined metric collectors. Each pair is the MetricCollector and its
+ * associated data (returned from MetricCollector.Start).
+ */
Review comment:
Not related to this PR but just in general about hiding. In this case,
we could use https://en.cppreference.com/w/cpp/language/pimpl to hide the
CallFrame def, recommend to come with a followup refactor
##########
File path: include/tvm/runtime/contrib/papi.h
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/*!
+ * \brief Performance counters for profiling via the PAPI library.
+ */
+#ifndef TVM_RUNTIME_CONTRIB_PAPI_H_
+#define TVM_RUNTIME_CONTRIB_PAPI_H_
+
+#include <tvm/runtime/container/array.h>
+#include <tvm/runtime/container/map.h>
+#include <tvm/runtime/profiling.h>
+
+#include <string>
+#include <unordered_map>
+#include <vector>
+
+namespace tvm {
+namespace runtime {
+namespace profiling {
+
+/*! \brief MetricCollectorNode for PAPI metrics.
+ *
+ * PAPI (Performance Application Programming Interface) collects metrics on a
+ * variety of platforms including cpu, cuda and rocm.
+ *
+ * PAPI is avaliable at https://bitbucket.org/icl/papi/src/master/.
+ */
+struct PAPIMetricCollectorNode final : public MetricCollectorNode {
Review comment:
Given this is a implementation of an existing interface, we usually
prefer hide as much as possible. As a result, let us to start as private
header(move the def to cc file or the header file to src)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
