masahi commented on a change in pull request #8443:
URL: https://github.com/apache/tvm/pull/8443#discussion_r670345010
##########
File path: include/tvm/relay/attrs/nn.h
##########
@@ -1463,6 +1463,21 @@ struct NLLLossAttrs : public
tvm::AttrsNode<NLLLossAttrs> {
}
}; // struct NLLLossAttrs
+/*! \brief Attributes used in Im2col operator */
+struct Im2colAttrs : public tvm::AttrsNode<Im2colAttrs> {
+ Array<IndexExpr> kernel_size;
+ Array<IndexExpr> dilation;
+ Array<IndexExpr> padding;
+ Array<IndexExpr> stride;
Review comment:
I don't see why you can't use `Array<Integer>`. There is no need to
follow `Conv2DAttrs`, if all attributes in im2col ops are integer constant,
there is no point using `Array<IndexExpr>` and it just makes your
implementation unnecessarily complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
