jinhongyii commented on a change in pull request #8467:
URL: https://github.com/apache/tvm/pull/8467#discussion_r671718120
##########
File path: src/arith/rewrite_simplify.cc
##########
@@ -881,7 +883,7 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const
FloorModNode* op) {
TVM_TRY_REWRITE_IF(floormod(x + y * c1, c2), floormod(x, c2),
c2.Eval()->value > 0 && c1.Eval()->value %
c2.Eval()->value == 0);
-
+ TVM_TRY_REWRITE_IF(floormod(x * c1, x * c2), x * floormod(c1, c2),
c2.Eval()->value != 0);
Review comment:
These lines are added to support symbolic split/fuse in some simple
cases, but it still can't handle situations where there are 2 or more symbolic
vars. Do you think we should support this simple situation for now by merging
it in a new PR or we put it aside and support the complete symbolic usage after
we improve symbolic divisible check in iter_affine_map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
