vinx13 commented on a change in pull request #8492:
URL: https://github.com/apache/tvm/pull/8492#discussion_r673338148
##########
File path: python/tvm/auto_scheduler/utils.py
##########
@@ -306,6 +307,7 @@ def _func_wrapper(que, func, args, kwargs,
add_thread_wrapper):
def call_func_with_timeout(timeout, func, args=(), kwargs=None,
add_thread_wrapper=False):
"""Call a function with timeout"""
que = multiprocessing.Queue(2)
+ process = PopenWorker()
Review comment:
yes, and `PopenWorker` supports for `timeout` argument in `send` which
is a builtin mechanism of calling with timeout, so queue is no longer needed,
this code block can be simplified
##########
File path: python/tvm/autotvm/tuner/xgboost_cost_model.py
##########
@@ -161,7 +162,8 @@ def _reset_pool(self, space, target, task):
_extract_space = space
_extract_target = target
_extract_task = task
- self.pool = multiprocessing.Pool(self.num_threads)
+ self.pool = popen_pool.PopenPoolExecutor(self.num_threads)
+ # self.pool = multiprocessing.Pool(self.num_threads)
Review comment:
remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
