comaniac commented on a change in pull request #8383:
URL: https://github.com/apache/tvm/pull/8383#discussion_r675048400
##########
File path: python/tvm/testing.py
##########
@@ -375,11 +376,12 @@ def _check_forward(constraints1, constraints2, varmap,
backvarmap):
def _get_targets(target_str=None):
if target_str is None:
target_str = os.environ.get("TVM_TEST_TARGETS", "")
+ # Use dict instead of set for de-duplication so that the
+ # targets stay in the order specified.
+ target_names = list({t.strip(): None for t in target_str.split(";") if
t.strip()})
- if len(target_str) == 0:
- target_str = DEFAULT_TEST_TARGETS
-
- target_names = set(t.strip() for t in target_str.split(";") if t.strip())
+ if len(target_names) == 0:
+ target_names = DEFAULT_TEST_TARGETS
Review comment:
nit
```suggestion
if not target_names:
target_names = DEFAULT_TEST_TARGETS
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
