areusch commented on a change in pull request #8503:
URL: https://github.com/apache/tvm/pull/8503#discussion_r675887363
##########
File path: src/runtime/profiling.cc
##########
@@ -228,6 +228,71 @@ String ReportNode::AsCSV() const {
return s.str();
}
+namespace {
+void print_metric(std::ostream& os, ObjectRef o) {
+ if (o.as<StringObj>()) {
+ os << "\"" << Downcast<String>(o) << "\"";
+ } else if (const CountNode* n = o.as<CountNode>()) {
+ os << "{\"count\":" << std::to_string(n->value) << "}";
+ } else if (const DurationNode* n = o.as<DurationNode>()) {
+ os << "{\"microseconds\":" << std::to_string(n->microseconds) << "}";
+ } else if (const PercentNode* n = o.as<PercentNode>()) {
+ os << "{\"percent\":" << std::to_string(n->percent) << "}";
+ } else {
+ LOG(FATAL) << "Unprintable type " << o->GetTypeKey();
+ }
+}
+} // namespace
+
+String ReportNode::AsJSON() const {
+ std::ostringstream s;
+ // DMLC's JSONWriter does not allow us to write a key value pair without
+ // implementing Write for the value. We want a specific write for the value,
+ // so we would have to implement a custom data structure for each type of
+ // value we want to print. Instead we construct the json by hand because it
+ // is easier.
+ s << "{";
+ s << "\"calls\":[";
+ for (size_t i = 0; i < calls.size(); i++) {
+ size_t j = 0;
+ s << "{";
+ for (const auto& kv : calls[i]) {
+ s << "\"" << kv.first << "\":";
Review comment:
also here
##########
File path: src/runtime/profiling.cc
##########
@@ -228,6 +228,71 @@ String ReportNode::AsCSV() const {
return s.str();
}
+namespace {
+void print_metric(std::ostream& os, ObjectRef o) {
+ if (o.as<StringObj>()) {
+ os << "\"" << Downcast<String>(o) << "\"";
Review comment:
should we worry about escaping here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
