areusch commented on a change in pull request #8382: URL: https://github.com/apache/tvm/pull/8382#discussion_r677036052
########## File path: .pre-commit-config.yaml ########## @@ -0,0 +1,40 @@ +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v2.5.0 + hooks: + - id: check-added-large-files + - id: check-merge-conflict + - id: check-yaml + - id: end-of-file-fixer + - repo: local + hooks: + - id: run-file-types + name: Checking File Types... + entry: python3 tests/lint/check_file_type.py + language: system + always_run: true + pass_filenames: false + - id: run-headers-check + name: Checking ASF License Headers... + entry: tests/lint/check_asf_header.sh --local + language: system + always_run: true + pass_filenames: false + - id: run-black Review comment: i don't have one offhand, but if you look at the default pylint bug template, they want you to run `pylint --version` and that outputs the exact versions of python, astroid, and pylint used to trigger the bug. if we are considering the case where `pylint` is the lone thing installed into a venv, the bug would have to essentially be a released regression in `astroid`. if we're considering a case where other things dependent on e.g. `astroid` were installed (especially after `pylint` was installed), then i think it'd be easier to contrive a case (i _think _ if another package locked `astroid` to an arbitrary version, pip < 20.3 could downgrade it past `pylint`'s `install_requires`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
