Lunderberg commented on a change in pull request #8532:
URL: https://github.com/apache/tvm/pull/8532#discussion_r678572119
##########
File path: python/tvm/testing/__init__.py
##########
@@ -14,13 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-[pytest]
-markers =
- gpu: mark a test as requiring a gpu
- tensorcore: mark a test as requiring a tensorcore
- cuda: mark a test as requiring cuda
- opencl: mark a test as requiring opencl
- rocm: mark a test as requiring rocm
- vulkan: mark a test as requiring vulkan
- metal: mark a test as requiring metal
- llvm: mark a test as requiring llvm
+"""Namespace for tvm testing utilities"""
+
+from .testing import *
Review comment:
I think that makes sense. That would allow `testing.py` to have
anything that is expected to be used externally, such as
`tvm.testing.assert_allclose`, while `plugin.py` has all the interactions with
the pytest framework itself. I want to wait for #8542 to be resolved first to
avoid annoying merge conflicts, but a wider split makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
