hogepodge commented on a change in pull request #8568:
URL: https://github.com/apache/tvm/pull/8568#discussion_r678590637
##########
File path: docs/install/from_source.rst
##########
@@ -73,6 +74,15 @@ linux operating systems, execute (in a terminal):
sudo apt-get update
sudo apt-get install -y python3 python3-dev python3-setuptools gcc
libtinfo-dev zlib1g-dev build-essential cmake libedit-dev libxml2-dev
+On macOS, whether using an Intel or M1 Mac, we support using homebrew. Make
sure to follow the post installation steps for each of the below commaands.
Review comment:
sp: commaands
Suggested edit:
"Use Homebrew to install the required dependencies for macOS running either
the Intel or M1 processors. You must follow the post-installation steps
specified by Homebrew to ensure the dependencies are correctly installed and
configured."
##########
File path: docs/install/from_source.rst
##########
@@ -293,6 +303,17 @@ like ``virtualenv``.
pip3 install --user tornado psutil xgboost cloudpickle
+Note on M1 macs, you may have trouble installing xgboost / scipy. A workaround
for this is to do the following commands:
Review comment:
I like to explain why there might be an issue. For example, it looks
like OPENBLAS needs to be installed and configured. Stating that helps future
readers and contributors understand what the problem is, and possibly update
the instructions if the issue is resolved. So, for example:
"`scipy` and `xgboost` requires some additional dependencies to be
installed, including `openblas` and its dependencies. Use the following
commands to install `scipy` and `xgboost` with the required dependencies and
configuration."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
