masahi commented on a change in pull request #8571:
URL: https://github.com/apache/tvm/pull/8571#discussion_r678856133
##########
File path: tests/python/unittest/test_tir_ir_builder.py
##########
@@ -554,6 +554,147 @@ def check_target(target):
check_target(target)
[email protected]_gpu
Review comment:
Thanks for a good suggestion. Moved new test cases to
`test_tir_transform_merge_dynamic_shared_memory_allocations.py` and added
verification on the output of the new pass.
I'm not familiar with TVMScript (also never liked hybrid script tbh). Now
that I've written the test using IR builder, I don't have a big motivation to
do rewrite. But I'll look over existing TVMScript examples and see if I can do
the rewrite quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
