Mousius commented on pull request #8280: URL: https://github.com/apache/tvm/pull/8280#issuecomment-888942599
> @Mousius the problem is we have precedent for CamelCase in our C code--i'm not personally opposed to what you say, but i think the change should be a blanket change done in a separate PR and announced with RFC + style guide update. Oh dear, I see a different conflict here with https://discuss.tvm.apache.org/t/mini-rfc-name-mangling-in-aot/9907 which began using the `tvmgen_` prefixes and C-style signatures? I've used this machinery in this PR following the example set by the existing AOT model descriptor and structures. If we're going to change that to `TVMGen_` we should do that outside this PR also? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
