Mousius commented on a change in pull request #8423:
URL: https://github.com/apache/tvm/pull/8423#discussion_r679422813
##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -468,7 +468,14 @@ class AOTExecutorCodegen : public ExprVisitor {
Target target;
// Handle external function
- if (func->GetAttr<String>(attr::kCompiler).defined()) {
+ // TODO(@Mousius): Move this to relying only on Target attributes rather
than kCompiler
+ auto external_compiler = func->GetAttr<String>(attr::kCompiler).defined();
Review comment:
Now actually contains compiler as a string in latest patch
##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -468,7 +468,14 @@ class AOTExecutorCodegen : public ExprVisitor {
Target target;
// Handle external function
- if (func->GetAttr<String>(attr::kCompiler).defined()) {
+ // TODO(@Mousius): Move this to relying only on Target attributes rather
than kCompiler
Review comment:
Tracking issue raised :smile_cat:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
