Lunderberg commented on a change in pull request #8576:
URL: https://github.com/apache/tvm/pull/8576#discussion_r679429742
##########
File path: python/tvm/testing.py
##########
@@ -379,7 +379,7 @@ def _get_targets(target_str=None):
if len(target_str) == 0:
target_str = DEFAULT_TEST_TARGETS
- target_names = set(t.strip() for t in target_str.split(";") if t.strip())
+ target_names = list(sorted(set(t.strip() for t in target_str.split(";") if
t.strip())))
Review comment:
A thought from this morning. Do we want to have the list in sorted
order, or in the order specified by `target_str`? Either way would be
deterministic, but I'd lean toward the latter so that we can have explicit
control over the order of targets. We can get this behavior if we use a `dict`
instead of a `set` for removing duplicates.
`target_names = list({t.strip():None for t in target_str.split(';') if
t.strip()})`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
