ganler commented on pull request #8586: URL: https://github.com/apache/tvm/pull/8586#issuecomment-889426080
@ I guess this API is usually confusing because even some tutorials misuse it. I did some investigation finding that there're at least 4 public inquiries regarding these APIs on TVM discussion. And I also found some code snippets that misuse it just like the ONNX/Keras tutorial do. - https://discuss.tvm.apache.org/t/whats-the-difference-between-build-and-create-executor-in-tvm-relay-build-module/1967 - https://discuss.tvm.apache.org/t/what-the-difference-between-relay-build-module-create-executor-and-tvm-contrib-graph-executor-graphmodule/10398 - https://discuss.tvm.apache.org/t/questions-about-tvm-executors-and-its-apis/10289 - https://discuss.tvm.apache.org/t/what-is-the-difference-between-relay-build-module-create-executor-and-relay-build/4675 But I do like its design rationale which is to provide different executor in an unified API. This PR is a quick fix regarding the tutorials. I think we may open a channel to discuss if it is necessary to refactor the executor APIs on the TVM discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
