Lunderberg commented on a change in pull request #8602:
URL: https://github.com/apache/tvm/pull/8602#discussion_r680238813
##########
File path: src/runtime/vulkan/vulkan_device_api.h
##########
@@ -106,7 +106,7 @@ class VulkanDeviceAPI final : public DeviceAPI {
* Returns the results of feature/property queries done during the
* device initialization.
*/
- void GetTargetProperty(Device dev, const std::string& property, TVMRetValue*
rv);
+ void GetTargetProperty(Device dev, const std::string& property, TVMRetValue*
rv) final;
Review comment:
It isn't strictly necessary, but I try to be in the habit of including
it for virtual functions that aren't intended to be subclassed further. It's
always safe to remove `final` later, but until then it serves as a warning to
my future self that I should be look into the class's implementation in detail
before making any subclass of it.
I can go either way on having it or not, since `final` could be interpreted
either as "not intended to be subclassed, so take a careful look first" or as
"intended not to be subclassed, please don't change it". I tend to take the
first interpretation, but the second is completely valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
