comaniac commented on pull request #8556: URL: https://github.com/apache/tvm/pull/8556#issuecomment-891185932
AFAIK, other frontends also have the similar issue. For example, ONNX graph also put some shapes to the model parameters, but their constant values are maintained in the model artifacts when the model is frozen, so it may just need `extra_param_names`. As a result, instead of fixing this issue one-by-one, I'm wondering if we could have a unified solution. Specifically, can we do the following to achieve the same goal? 1. Get a dynamic graph via a frontend. 2. Bind parameters (i.e., `batch_size`) by name. 3. Run `DynamicToStatic` to get a static graph. It seems to me that the above flow should result in the same outcome without this PR (assuming `DynamicToStatic` is doing a good job). If that works, it could be the best practice for not only TF but all frameworks IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
