mbrookhart opened a new pull request #8621:
URL: https://github.com/apache/tvm/pull/8621


   https://github.com/apache/tvm/pull/7438 Accidentally disabled the ONNX unit 
tests on CPU, and since then we've had a few regressions creep in. We've been 
attempting to enable the ONNX tests in a CPU only job at #8189, but we've hit 
issues with pytorch in the CPU docker image. 
   
   This PR instead refactors the onnx test file to use the 
`parametrize_targets` flow.
   it
   1) adds that decorator to every test
   2) inlines helper functions that are only used in one test as closures
   3) removes the for loops over enabled targets so pytest will run every test 
on each target individually
   4) removes -m gpu from the invocation of the pytest call in CI
   
   This will re-enable a bunch of tests that have been disabled in CI and allow 
us to more easily skip tests that fail only on one target.
   
   Thank you!
   
   cc @electriclilies @Lunderberg @tkonolige @jwfromm @masahi 
   
   P.S. This conflicts somewhat with #8574 , but I really like the onnx node 
file changes in there.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to