vvchernov commented on a change in pull request #8599:
URL: https://github.com/apache/tvm/pull/8599#discussion_r681657427
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -2142,58 +2142,72 @@ class LSTM(RNN):
"""Operator converter for LSTM"""
@classmethod
- def generate_lstm(
- cls, X_steps, H_t, C_t, W, R, B, p_i, p_f, p_o, f_act, g_act, h_act,
backwards=False
- ):
- """Create an unrolled lstm loop.
-
- See https://github.com/onnx/onnx/blob/master/docs/Operators.md for
math.
+ def unbind(cls, data, axis=0):
Review comment:
Should I do the same for pytorch frontend?
https://github.com/apache/tvm/blob/09e234dfd9dd8adf77cf4b6c39a371dd74530e14/python/tvm/relay/frontend/pytorch.py#L2095
More over just now I'm trying to implement this method (unbind) as relay
operation, I follow to split op for this. But I think it will be separated PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
