comaniac commented on a change in pull request #8623:
URL: https://github.com/apache/tvm/pull/8623#discussion_r682104340
##########
File path: include/tvm/tir/schedule/schedule.h
##########
@@ -299,6 +302,20 @@ class Schedule : public runtime::ObjectRef {
*/
TVM_DLL static Schedule Concrete(IRModule mod, int debug_mode,
ScheduleErrorRenderLevel
error_render_level);
+ /*!
+ * \brief Construct a traced concrete TensorIR schedule from an IRModule
+ * \param mod The IRModule to be scheduled
+ * \param debug_mode Do extra correctness checking after the class creation
+ * and each time after calling the Replace method.
+ * \param error_render_level The level of error rendering
+ * \return The concrete schedule created
+ * \sa ScheduleDebugMask
+ * \note The checks performed include:
+ * 1) VerifySRefTree
+ * 2) VerifyCachedFlags
+ */
+ TVM_DLL static Schedule Traced(IRModule mod, int debug_mode,
+ ScheduleErrorRenderLevel error_render_level);
Review comment:
Maybe `TracedSchedule` is more precise. So does `ConcreteSchedule`.
##########
File path: python/tvm/tir/schedule/schedule.py
##########
@@ -63,7 +63,37 @@ def __init__(self) -> None:
RAND_VAR_TYPE = Union[ExprRV, BlockRV, LoopRV] # pylint: disable=invalid-name
# Update to `Literal["detail", "fast", "none"]` once upgraded to python3.8
-ERROR_RENDER_LEVEL_CANDIDATES = Union[str] # pylint: disable=invalid-name
+_ERROR_RENDER_LEVEL = {
+ "detail": 0,
+ "fast": 1,
+ "none": 2,
+}
+
+
+def _preprocess_constructor_arguments(
+ mod: Union[PrimFunc, IRModule],
+ debug_mode: Union[bool, int] = False,
+ error_render_level: str = "detail",
+) -> Tuple[IRModule, int, int]:
+ # preprocess `mod`
+ if isinstance(mod, PrimFunc):
+ mod = IRModule({"main": mod})
+ # preprocess `debug_mode`
+ if isinstance(debug_mode, bool):
+ if debug_mode:
+ debug_mode = -1
+ else:
+ debug_mode = 0
Review comment:
nit
```suggestion
debug_mode -1 if debug_mode else 0
```
##########
File path: python/tvm/tir/schedule/schedule.py
##########
@@ -115,39 +139,49 @@ def __init__(
1) VerifySRefTree
2) VerifyCachedFlags
"""
- if isinstance(mod, PrimFunc):
- mod = IRModule({"main": mod})
- if isinstance(debug_mode, bool):
- if debug_mode:
- debug_mode = -1
- else:
- debug_mode = 0
- if not isinstance(debug_mode, int):
- raise TypeError(f"`debug_mode` should be integer or boolean, but
gets: {debug_mode}")
- if error_render_level not in Schedule.ERROR_RENDER_LEVEL:
- raise ValueError(
- 'error_render_level can be "detail", "fast", or "none", but
got: '
- + f"{error_render_level}"
- )
+ # call the constructor
self.__init_handle_by_constructor__(
- _ffi_api.ConcreteSchedule, # type: ignore # pylint:
disable=no-member
- mod,
- debug_mode,
- Schedule.ERROR_RENDER_LEVEL.get(error_render_level),
+ _ffi_api.TracedSchedule, # type: ignore # pylint:
disable=no-member
+ *_preprocess_constructor_arguments(
+ mod,
+ debug_mode,
+ error_render_level,
+ ),
+ )
+
+ @staticmethod
+ def _create_non_traced(
+ mod: Union[PrimFunc, IRModule],
+ *,
+ debug_mode: Union[bool, int] = False,
+ error_render_level: str = "detail",
+ ) -> "Schedule":
+ """Construct a non-traced TensorIR schedule class from an IRModule."""
+ return _ffi_api.ConcreteSchedule( # type: ignore # pylint:
disable=no-member
+ *_preprocess_constructor_arguments(
+ mod,
+ debug_mode,
+ error_render_level,
+ )
)
########## Utilities ##########
@property
def mod(self) -> IRModule:
"""Returns the AST of the module being scheduled"""
- return _ffi_api.ScheduleModule(self) # type: ignore # pylint:
disable=no-member
+ return _ffi_api.ScheduleGetMod(self) # type: ignore # pylint:
disable=no-member
@property
def state(self) -> ScheduleState:
"""Returns the ScheduleState in the current schedule class"""
return _ffi_api.ScheduleGetState(self) # type: ignore # pylint:
disable=no-member
+ @property
+ def trace(self) -> Optional[Trace]:
+ """Returns the internally maintained trace of scheduling program
execution"""
Review comment:
Better to also explain the case that may return None.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
