Mousius commented on pull request #8652: URL: https://github.com/apache/tvm/pull/8652#issuecomment-892845455
@comaniac, that's a good thought actually, we run only a reduced set of of flake8 options. Looking at the errors enabled: * `E9` looks like errors which would immediately error when tests start executing? * `F63` isn't covered much in pylint but it seems to cover some interesting edge cases in Python * `F7` is mostly covered by pylint and I'd suggest that mypy covers most of the missing checks in tandem with running the doctest's if we had them. Flake8 | Pylint | Description -----|-------------------------------------------------|---- E901 || SyntaxError or IndentationError E902 || IOError F631 | W0199 | assertion test is a tuple, which is always True F632 || use ==/!= to compare str, bytes, and int literals F633 || use of >> is invalid with print function F634 || if test is a tuple, which is always True F701 | E0103 | a break statement outside of a while or for loop | F702 | E0103 | a continue statement outside of a while or for loop F703 | E0116 | a continue statement in a finally block in a loop F704 | E0105 | a yield or yield from statement outside of a function F705 | E0106 | a return statement with arguments inside a generator F706 | E0104 | a return statement outside of a function/method F707 | E0701 ? | an except: block as not the last exception handler F721 || syntax error in doctest F722 || syntax error in forward annotation F723 || syntax error in type comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
