mbs-octoml commented on a change in pull request #8597:
URL: https://github.com/apache/tvm/pull/8597#discussion_r683006898
##########
File path: python/tvm/relay/analysis/analysis.py
##########
@@ -433,8 +433,7 @@ def get_calibration_data(mod, data):
mod = _ffi_api.get_calibrate_module(mod)
mod = transform.Inline()(mod)
- ref_ex = build_module.create_executor("graph", mod=mod, device=cpu(0))
- ref_res = ref_ex.evaluate()(**data)
+ ref_res = build_module.create_executor("graph", mod=mod,
device=cpu(0)).evaluate()(**data)
Review comment:
Agree, and I'm very close to doing it now since I went and rejigged
**all** the create_executor/evaluate calls anyway. Left a TODO(mbs). Once we
have issue tracking conventions I'll rework the TODOs into TODO(some specific
issue) so we can organize this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
