Mousius commented on a change in pull request #8300:
URL: https://github.com/apache/tvm/pull/8300#discussion_r683274348
##########
File path: python/tvm/relay/op/contrib/ethosn.py
##########
@@ -61,6 +61,53 @@ def partition_for_ethosn(mod, params=None, **opts):
-------
ret : annotated and partitioned module.
"""
+ if opts:
+ tops = opts.get("tops", None)
+ ple_ratio = opts.get("ple_ratio", None)
+ sram_size = opts.get("sram_size", None)
+ if tops or ple_ratio or sram_size:
+ raise ValueError(
+ "Setting tops, ple_ratio or sram_size has no effect when
targeting Ethos-N77"
+ )
+
+ if params:
+ mod["main"] = bind_params_by_name(mod["main"], params)
+
+ seq = tvm.transform.Sequential(
+ [
+ transform.InferType(),
+ transform.MergeComposite(pattern_table()),
+ transform.AnnotateTarget("ethos-n"),
+ transform.MergeCompilerRegions(),
+ transform.PartitionGraph(),
+ ]
+ )
+
+ return seq(mod), None
+
+
+def partition_for_ethosn78(mod, params=None, **opts):
+ """Partition the graph greedily offloading supported
+ operators to Arm Ethos-N NPU.
+
+ Parameters
+ ----------
+ mod : Module
+ The module to run passes on.
+ params : Optional[Dict[str, NDArray]]
+ Constant input parameters.
+
+ Returns
+ -------
+ ret : annotated and partitioned module.
+ """
+ config = opts
Review comment:
`config = opts or {}`
##########
File path: python/tvm/driver/tvmc/composite_target.py
##########
@@ -23,7 +23,8 @@
import tvm.contrib.target.vitis_ai # pylint: disable=unused-import
from tvm.relay.op.contrib.arm_compute_lib import partition_for_arm_compute_lib
-from tvm.relay.op.contrib.ethosn import partition_for_ethosn
+from tvm.relay.op.contrib.ethosn import partition_for_ethosn77
+from tvm.relay.op.contrib.ethosn import partition_for_ethosn78
Review comment:
These can be combined into one import:
`from tvm.relay.op.contrib.ethosn import partition_for_ethosn77,
partition_for_ethosn78`
##########
File path: python/tvm/relay/op/contrib/ethosn.py
##########
@@ -61,6 +61,53 @@ def partition_for_ethosn(mod, params=None, **opts):
-------
ret : annotated and partitioned module.
"""
+ if opts:
+ tops = opts.get("tops", None)
+ ple_ratio = opts.get("ple_ratio", None)
+ sram_size = opts.get("sram_size", None)
+ if tops or ple_ratio or sram_size:
+ raise ValueError(
+ "Setting tops, ple_ratio or sram_size has no effect when
targeting Ethos-N77"
+ )
+
+ if params:
+ mod["main"] = bind_params_by_name(mod["main"], params)
+
+ seq = tvm.transform.Sequential(
+ [
+ transform.InferType(),
+ transform.MergeComposite(pattern_table()),
+ transform.AnnotateTarget("ethos-n"),
+ transform.MergeCompilerRegions(),
+ transform.PartitionGraph(),
+ ]
+ )
+
+ return seq(mod), None
+
+
+def partition_for_ethosn78(mod, params=None, **opts):
+ """Partition the graph greedily offloading supported
+ operators to Arm Ethos-N NPU.
+
+ Parameters
+ ----------
+ mod : Module
+ The module to run passes on.
+ params : Optional[Dict[str, NDArray]]
+ Constant input parameters.
+
+ Returns
+ -------
+ ret : annotated and partitioned module.
+ """
+ config = opts
+ if not config:
+ config = {}
+
+ if config.get("variant", "").lower() != "ethos-n78":
Review comment:
This can be simplified to just `config["variant"] = "Ethos-N78"`
##########
File path: tests/python/contrib/test_ethosn/test_partition_params.py
##########
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Ethos-N partition parameter tests"""
+
+import pytest
+import tvm
+from tvm import relay
+import numpy as np
+
+from tvm.relay.op.contrib.ethosn import partition_for_ethosn77
+from tvm.relay.op.contrib.ethosn import partition_for_ethosn78
+
+fp32 = "float32"
+
+
+def test_ethosn78_partition_no_error():
+ a = relay.var("a", shape=[2, 7, 8, 8], dtype=fp32)
+ w = relay.const(np.random.uniform(-10, 10, (8, 7, 3, 3)).astype(fp32))
+ res = relay.nn.conv2d(a, w, kernel_size=(3, 3), padding=(1, 1),
channels=8, out_dtype=fp32)
+ b = relay.var("b", shape=[8], dtype=fp32)
+ res = relay.nn.bias_add(res, b, axis=1)
+
+ mod = tvm.IRModule.from_expr(res)
Review comment:
This looks like the same module repeated in the various tests, it'd be
worth wrapping this in a `pytest.fixture`, such as:
```
@pytest.fixture
def simple_mod():
a = relay.var("a", shape=[2, 7, 8, 8], dtype=fp32)
w = relay.const(np.random.uniform(-10, 10, (8, 7, 3, 3)).astype(fp32))
res = relay.nn.conv2d(a, w, kernel_size=(3, 3), padding=(1, 1),
channels=8, out_dtype=fp32)
b = relay.var("b", shape=[8], dtype=fp32)
res = relay.nn.bias_add(res, b, axis=1)
return tvm.IRModule.from_expr(res)
def test_ethosn78_partition_no_error(simple_mod):
opts = {"variant": "Ethos-N78"}
partition_for_ethosn78(simple_mod, **opts)
```
##########
File path: src/relay/backend/contrib/ethosn/codegen_ethosn.h
##########
@@ -227,7 +227,9 @@ NetworkWithIDs ConstructNetwork(const IRModule& mod, const
GlobalVar& var, const
/*! \brief Attributes to store the compiler options for Ethos-N */
struct EthosnCompilerConfigNode : public
tvm::AttrsNode<EthosnCompilerConfigNode> {
String variant;
- int sram_size_bytes;
+ String sram_size;
Review comment:
Why can't these be numeric types?
##########
File path: src/relay/backend/contrib/ethosn/ethosn_utils.h
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file src/relay/backend/contrib/ethosn/ethosn_utils.h
+ * \brief Ethos-N utility functions.
+ */
+
+#ifndef TVM_RELAY_BACKEND_CONTRIB_ETHOSN_ETHOSN_UTILS_H_
+#define TVM_RELAY_BACKEND_CONTRIB_ETHOSN_ETHOSN_UTILS_H_
Review comment:
As this file only includes variant specific logic, I'd suggest
`ethosn_variant.h` instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
