leandron commented on a change in pull request #8300:
URL: https://github.com/apache/tvm/pull/8300#discussion_r683366227
##########
File path: python/tvm/relay/op/contrib/arm_compute_lib.py
##########
@@ -69,7 +69,7 @@ def partition_for_arm_compute_lib(mod, params=None, **opts):
]
)
- return seq(mod)
+ return seq(mod), None
Review comment:
With the new return type, please update the docstrings.
This applies to all `partition_for_*` functions.
##########
File path: tests/python/driver/tvmc/test_tvmc_common.py
##########
@@ -241,6 +241,11 @@ def test_target_two_tvm_targets():
assert 0 == len(extra_targets)
+def test_target_from_cli__error_no_tvm_target_ethos_n78():
+ with pytest.raises(TVMCException):
+ _ = tvmc.common.target_from_cli("ethos-n78")
Review comment:
It should fail because `ethos-n78` is not a standalone codegen. It still
requires `c` or `llvm` to handle the CPU parts of the codegen.
##########
File path: tests/python/contrib/test_ethosn/test_partition_params.py
##########
@@ -0,0 +1,104 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Ethos-N partition parameter tests"""
Review comment:
It would be good to have tests also exercising parameters such as `tops`
and `ple_ratio` when asking for an `ethos-n78` target, so that we can see which
errors to expect from the underlying layers of the codegen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
