gromero edited a comment on pull request #8677: URL: https://github.com/apache/tvm/pull/8677#issuecomment-894441558
@mehrdadh Hi! The PR title says the test fails because of short timeout but your fix is reducing it even further afaics? Also I miss a bit a better commit message explaining more about the "rational/background" for changes in question do. Of course, they are simple in essence but for instance, the commit "71dfd4b" only mentions a "fix" in the title. It would be good to at least mention the occasion when it happens (which hardware, if it always happen or not, etc) for the future when people would be looking at the commit via `git log`. Thumbs up for using a patchset for the two changes (adding the parameter plus setting the proper timeout that worked for you). I think that a better elaboration of the commit messages in general will specially help others which are/will catch up with the TVM project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
