YuchenJin commented on a change in pull request #8501:
URL: https://github.com/apache/tvm/pull/8501#discussion_r684546402



##########
File path: src/relay/backend/te_compiler.cc
##########
@@ -349,6 +350,9 @@ class LowerTensorExpr : public ExprMutator {
       Map<GlobalVar, tir::PrimFunc> prim_fns;
 
       for (auto prim_fn : ext_func->funcs->functions) {
+        if (prim_fn.second->GetAttr<String>(attr::kCompiler).defined()) {

Review comment:
       Thanks @Mousius for elaborating it! I think you are right, and we can 
probably remove this loop because the `IRModule` should not contain a PrimFunc 
anyway for external functions, and we don't need to check it. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to