masahi commented on a change in pull request #8672:
URL: https://github.com/apache/tvm/pull/8672#discussion_r684604131



##########
File path: tests/python/relay/test_op_level6.py
##########
@@ -25,15 +25,14 @@
 
 @tvm.testing.uses_gpu
 def test_sort():
-    def verify_sort(shape, axis, is_ascend, is_dyn=False):
-
+    def verify_sort(shape, axis, is_ascend, is_dyn=False, in_dtype="float32"):

Review comment:
       Wouldn't that make the testing time double? This file is fairly slow to 
test (more than 3 min according to 
https://ci.tlcpack.ai/job/tvm/job/main/1384/testReport/ctypes.tests.python.relay/test_op_level6/)
 and I don't think fp16 tests need to run as often as fp32. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to