areusch commented on a change in pull request #8451:
URL: https://github.com/apache/tvm/pull/8451#discussion_r686147321
##########
File path: tests/python/unittest/test_tvm_testing_features.py
##########
@@ -210,5 +210,44 @@ def test_pytest_mark_covariant(self, request, target,
other_param):
self.check_marks(request, target)
[email protected](
+ bool(int(os.environ.get("TVM_TEST_DISABLE_CACHE", "0"))),
+ reason="Cannot test cache behavior while caching is disabled",
+)
+class TestCacheableTypes:
+ class EmptyClass:
+ pass
+
+ @tvm.testing.fixture(cache_return_value=True)
+ def uncacheable_fixture(self):
+ return self.EmptyClass()
+
+ @pytest.mark.xfail(reason="Requests cached fixture of uncacheable type",
strict=True)
Review comment:
seems like you could just invoke uncacheable_fixture from the test body,
no?
##########
File path: tests/python/unittest/test_tvm_testing_features.py
##########
@@ -210,5 +210,44 @@ def test_pytest_mark_covariant(self, request, target,
other_param):
self.check_marks(request, target)
[email protected](
+ bool(int(os.environ.get("TVM_TEST_DISABLE_CACHE", "0"))),
+ reason="Cannot test cache behavior while caching is disabled",
+)
+class TestCacheableTypes:
+ class EmptyClass:
+ pass
+
+ @tvm.testing.fixture(cache_return_value=True)
+ def uncacheable_fixture(self):
+ return self.EmptyClass()
+
+ @pytest.mark.xfail(reason="Requests cached fixture of uncacheable type",
strict=True)
Review comment:
seems like you could just invoke uncacheable_fixture() from the test
body, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
