jroesch commented on a change in pull request #8697:
URL: https://github.com/apache/tvm/pull/8697#discussion_r686182295



##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -774,14 +697,17 @@ class AOTExecutorCodegen : public ExprVisitor {
       mod_run = pack_calls(mod_run);
     }
 
-    // Update the lowered functions
+    ret.function_metadata = std::move(function_metadata_);

Review comment:
       Is it possible for us to remove the specialized `main` functions 
`FunctionInfo` field in LoweredModule? They should all be uniformly set inside 
of the lowering, and I think the specialized `main` is a hold over from Lily's 
code that could be cleaned up. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to