comaniac commented on a change in pull request #8712:
URL: https://github.com/apache/tvm/pull/8712#discussion_r686382635
##########
File path: tests/python/topi/python/test_topi_conv2d_nchw.py
##########
@@ -142,7 +142,7 @@ def test_conv2d_nchw(
if "int" in dtype:
tol = {"atol": 0, "rtol": 0}
elif dtype == "float32":
- tol = {"rtol": 1e-4, "atol": 1e-5}
+ tol = {"rtol": 1e-4, "atol": 1e-4}
Review comment:
Why we need to release the tol for float32? If it's only for a specific
target, then we should release the tol for that target instead of all cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
