masahi commented on a change in pull request #8669:
URL: https://github.com/apache/tvm/pull/8669#discussion_r687104130
##########
File path: tests/python/contrib/test_arm_compute_lib/test_dense.py
##########
@@ -154,7 +154,7 @@ def _get_expected_codegen(shape, weight_shape, units,
dtype, has_bias=False):
{
"op": "const",
"name": "",
- "attrs": {"shape": [[[weight_shape[0]]]], "dtype":
[[bias_dtype]]},
+ "attrs": {"shape": [[[1, weight_shape[0]]]], "dtype":
[[bias_dtype]]},
Review comment:
Thanks @lhutton1, given the failures I've seen, this seems like the
right fix. I'm confused with bias shape behavior too and why the change in my
PR could possibly affect it (the only change to `dense` op is the addition of
`InferCorrectLayout`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
