Lunderberg commented on a change in pull request #8735:
URL: https://github.com/apache/tvm/pull/8735#discussion_r687870820
##########
File path: docs/Makefile
##########
@@ -61,147 +62,176 @@ help:
@echo " coverage to run coverage check of the documentation (if
enabled)"
clean:
- rm -rf $(BUILDDIR)/*
+ rm -rf $(BUILDDIR)
+ rm -rf $(STAGINGDIR)
+ # Remove folders that have since been relocated into
+ # $(STAGINGDIR). This allows `task_sphinx_precheck.sh` to
+ # run, even if a commit that predates $(STAGINGDIR) was
+ # previously run on that node.
rm -rf gen_modules
Review comment:
Right now, these are intentionally present, so that CI nodes that have
the `docs/tutorials` folders get them cleared out over time, and so that PRs
based on branches before the `$(STAGINGDIR)` don't cause the issue to reappear.
After the change has been propagated, then I want to make a new PR to remove
these lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
