mbrookhart commented on a change in pull request #8741:
URL: https://github.com/apache/tvm/pull/8741#discussion_r688105051
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -23,6 +23,7 @@
import numpy as np
import tvm
from tvm.ir import IRModule
+from tvm.relay.transform.transform import ConvertLayout
Review comment:
Unused, remove
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -3607,6 +3608,7 @@ def _get_convert_map(opset):
"ConvInteger": ConvInteger.get_converter(opset),
# Random number generation.
"RandomUniform": RandomUniform.get_converter(opset),
+ "Celu": Celu.get_converter(opset),
Review comment:
Maybe stick this higher in the list by Relu to keep similar ops together?
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -4668,7 +4668,7 @@ def verify_eyelike(indata):
"test_cast_FLOAT_to_BFLOAT16",
"test_cast_FLOAT_to_STRING",
"test_cast_STRING_to_FLOAT",
- "test_celu",
+ # "test_celu",
Review comment:
Just remove, don't comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]