junrushao1994 commented on a change in pull request #8750:
URL: https://github.com/apache/tvm/pull/8750#discussion_r688863006
##########
File path: include/tvm/target/target.h
##########
@@ -54,7 +54,7 @@ class TargetNode : public Object {
/*! \brief Keys for this target */
Array<String> keys;
/*! \brief Collection of attributes */
- Map<String, ObjectRef> attrs;
+ Map<String, ObjectRef> attrs; // TODO(@electriclilies): Unify with
DictAttrs on IRModule
Review comment:
Target has their own attributions, for example, compute version for cuda
devices. Would you like to elaborate the reason why we need to unify we need to
unify this attrs into IRModule?
##########
File path: include/tvm/target/target.h
##########
@@ -54,7 +54,7 @@ class TargetNode : public Object {
/*! \brief Keys for this target */
Array<String> keys;
/*! \brief Collection of attributes */
- Map<String, ObjectRef> attrs;
+ Map<String, ObjectRef> attrs; // TODO(@electriclilies): Unify with
DictAttrs on IRModule
Review comment:
Target has its own attributions, for example, compute version for cuda
devices. Would you like to elaborate the reason why we need to unify we need to
unify this attrs into IRModule?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
