Yuan-Chuan-YUE commented on pull request #8756: URL: https://github.com/apache/tvm/pull/8756#issuecomment-899941744
Thanks for the reply @junrushao1994 ! Thanks for the comment @csullivan ! I will add unit test of `erf` in the opencl codegen. Should I also add unit test in cuda? To the best of my knowledge, the unit test in cuda provides vectorize intrinsic tests and there is a list to check math intrinsics but does not include `erf`. Also, `numpy` doesn't have `erf` causing this may need other math library to help checking the result, `math.erf` for example. Sorry for my less experience, if there is any misunderstanding, please don't refuse to offer your kind advice! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
