Mousius commented on a change in pull request #8780:
URL: https://github.com/apache/tvm/pull/8780#discussion_r691354156



##########
File path: tests/python/frontend/tflite/test_forward.py
##########
@@ -2618,6 +2617,27 @@ def test_forward_select():
             )
 
 
+def _test_fake_quant(value, min, max, num_bits):

Review comment:
       Rather than using this additional function, can you use 
[pytest.mark.parametrize](https://docs.pytest.org/en/6.2.x/parametrize.html) ?
   
   Something like:
   ```
   @pytest.mark.parametrize("quant_bits", [2, 4, 8, 16])
   @pytest.mark.parametrize("value,min,max", [
     [-10.11, -6, 6],
     // .. more here ...
   ])
   def test_fake_quant(value, min, max, quant_bits):
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to