junrushao1994 commented on a change in pull request #8767: URL: https://github.com/apache/tvm/pull/8767#discussion_r691552975
########## File path: src/tir/schedule/primitive/loop_transformation.cc ########## @@ -155,7 +177,7 @@ class HasAnnotationOrThreadBindingError : public ScheduleError { class OuterNotInnerParent : public ScheduleError { public: explicit OuterNotInnerParent(IRModule mod, For outer, For inner) - : mod_(mod), outer_(std::move(outer)), inner_(std::move(inner)) {} + : mod_(std::move(mod)), outer_(std::move(outer)), inner_(std::move(inner)) {} Review comment: You don't actually need this `std::move` here due to copy elision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org