vinx13 commented on a change in pull request #8789:
URL: https://github.com/apache/tvm/pull/8789#discussion_r691688309
##########
File path: python/tvm/contrib/popen_pool.py
##########
@@ -276,14 +288,19 @@ class PopenPoolExecutor:
behavior of multiprocessing.pool().
"""
- def __init__(self, max_workers=None, timeout=None):
+ def __init__(self, max_workers=None, timeout=None, initializer=None,
initargs=()):
Review comment:
please add docs for the args
##########
File path: python/tvm/contrib/popen_pool.py
##########
@@ -128,6 +132,9 @@ def _start(self):
if self._proc is not None:
return
+ if self._initializer is not None:
Review comment:
remove this
##########
File path: python/tvm/testing/popen_pool.py
##########
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+# pylint: disable=invalid-name, missing-function-docstring
+"""Common functions for popen_pool test cases"""
+
+a = 0
Review comment:
consider using meaningful variable names
##########
File path: python/tvm/contrib/popen_pool.py
##########
@@ -86,8 +86,12 @@ class PopenWorker:
API to interact with a separate process via Popen.
"""
- def __init__(self):
+ def __init__(self, initializer=None, initargs=()):
Review comment:
please add docs for the args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
