junrushao1994 commented on pull request #8767: URL: https://github.com/apache/tvm/pull/8767#issuecomment-903177719
Thanks @jinhongyii! The PR mostly looks good to me now in terms of the algorithm side. I prefer to consolidate the logic into several semantically meaningful methods, so that the reader could understand the workflow really quick and dig into particular pieces of their interest if they really need to. On the other hand, a huge chunk of spaghetti code is barely comprehensible at the first glance, which if I were you I would probably would rather avoid. But afterall, it is a readability issue which people have their own preference, so it is fine if you don't like it and don't want to change anything. Please fix the nitpicks and let's get the PR merged ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
